Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace some eltype with genetic typing, use isone and iszero for typ… #19

Merged
merged 15 commits into from
Mar 8, 2024
Merged

replace some eltype with genetic typing, use isone and iszero for typ… #19

merged 15 commits into from
Mar 8, 2024

Conversation

jbytecode
Copy link
Contributor

@jbytecode jbytecode commented Mar 7, 2024 •
edited
Loading

  • replace some eltype() usage with generic types
  • use iszero for if n == 0 and isone for if n == 1 for more type stable code
  • remove multiline string in error() calls
  • Introduce return types for some functions
  • Add tests for untested functions
  • Improve test framework with less dependencies
  • Introduce a command line utility to report current coverage ratio

@jbytecode
replace some eltype with genetic typing, use isone and iszero for typ…
41a8352 
…e stable code
@jbytecode
one more isone(-s)
4fc72bf
@jbytecode
get rid of multiple calls of size() in togeometrybasics_faces funct…
b1da423 
…ions
@jbytecode
remove multiple calls of length in the same environment
0f5a8db
@jbytecode
fix error messages
35afc2a
@jbytecode
merge two variants of wrapindex() functions within one
5bc7a6e
@jbytecode
define return types for some functions
5127f3d
@jbytecode
add .gitignore entry for code coverate files (*.cov)
5201380
@jbytecode
add tests for untested functions
c92423c
@jbytecode
add test for nbezier
2e9fe64
@jbytecode
increate coverage by introducing new tests for untested functions
e82c2a9
@jbytecode
Remove GeometryBasics from test dependencies and export it from Comod…
ae9eba6 
…o.jl
@jbytecode
add tests for untested functions
a484b0e
@jbytecode
add a command line utility to report test coverage ratio
d2aba6a
@jbytecode
catch Coverage.jl from dev project rather than the main environment
7f5cf8e
@jbytecode
Copy link
Contributor Author

@Kevin-Mattheus-Moerman - Sorry for flooding, it may have much time to review all the things.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman merged commit 088e380 into COMODO-research:main Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbytecode @Kevin-Mattheus-Moerman